Restore support for nested Scrapy items #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 4 4
Lines 253 254 +1
=======================================
+ Hits 252 253 +1
Misses 1 1
Continue to review full report at Codecov.
|
ejulio
approved these changes
Oct 26, 2020
ejulio
approved these changes
Nov 3, 2020
wRAR
approved these changes
Nov 5, 2020
This was referenced Mar 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
The attrs syntax is not supported in Python 3.5. Since Python 3.5 reached end-of-life, instead of making test code more complex to support 3.5, I went ahead and removed official support for 3.5 (it will actually still work, but not officially since we are not covering it in tests).
Originally I also added 3.9 official support, but it looks like 3.9 has not reached Travis yet.