Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The re-introduction of nested item support caused a significant performance degradation #50

Closed
Gallaecio opened this issue Mar 12, 2022 · 0 comments · Fixed by #51
Closed
Labels
enhancement New feature or request

Comments

@Gallaecio
Copy link
Member

I have a CPU-bound Scrapy project that becomes 50% slower after #29.

I believe the problem is that is_item is not a cheap call, and it will potentially become more expensive as itemadapter extends support to additional types.

I think we may be able to reimplement this function so that it does not call is_item at all, but still does not treat item-like objects as sequences.

@Gallaecio Gallaecio added the enhancement New feature or request label Mar 12, 2022
@kmike kmike closed this as completed in #51 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant