Update dependencies, drop py35, test in py310, improve itemadapter performance #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itemadapter
usagesix
as test dependencyCalling
itemadapter.ItemAdapter.is_item
directly instead of theitemadapter.is_item
alias (which importsitemadapter.ItemAdapter
on each call) is faster:(At scrapy/itemadapter@1203b5e, with a 2020 Macbook Pro, Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz)
See also scrapy/itemadapter#59 and the issues/PRs linked there.