-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate sh_scrapy.compat module #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 95.06% 95.53% +0.46%
==========================================
Files 14 14
Lines 750 739 -11
==========================================
- Hits 713 706 -7
+ Misses 37 33 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe everything is ok, I don't see any limitations, however, I don't feel comfortable evaluating the pull request alone. This time, are we going to wait for another approver?
Use
scrapy.utils.python.to_bytes/to_unicode
instead, available at least since Scrapy 1.6 which is currently the minimum required version.