Skip to content

Fix template postCommit for Ruby 2.7 / Bundler 2.2 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yselkowitz wants to merge 1 commit into from
Closed

Fix template postCommit for Ruby 2.7 / Bundler 2.2 #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openshift/templates/rails-postgresql-persistent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
}
],
"postCommit": {
"script": "bundle exec rake test"
"script": "/usr/bin/bundle exec rake test"
Copy link

@dperaza4dustbit dperaza4dustbit Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @yselkowitz thanks for researching this one

Copy link

@dperaza4dustbit dperaza4dustbit Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on my PR on sample and will report here

Copy link

@dperaza4dustbit dperaza4dustbit Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now on openshift/cluster-samples-operator#408 rail test is not failing. Still see some other errors but this fix seems to be working

}
}
},
Expand Down
2 changes: 1 addition & 1 deletion openshift/templates/rails-postgresql.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
}
],
"postCommit": {
"script": "bundle exec rake test"
"script": "/usr/bin/bundle exec rake test"
}
}
},
Expand Down