-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorials infrastructure: switch to text-based notebook workflow #59
Closed
Closed
Changes from 16 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7ee54d5
Adding jupytext options to Makefile
0803983
Migrating from the "old" format: toc is not a mapping
55ff765
Moving builds to their folder
f3bf746
Building site instead of book
de2d146
Adding Makefile on website
e345a61
Removing website Makefile refs
1d4e64c
Adding website/conf.py
37c53d5
Starting index.md
3086296
Adding Indices and tables to index.md
0c22b39
Ignoring website local builds
568fe59
An example — testing jupytext conversion
2437a6a
Adding example to toctree on index.md
831741f
Creating a link from website/images to ../images
e818bc4
Testing toc structure
747d842
Organizing folders
f217e16
Changing intro.md
9244886
Testing python instead of ipython3 on {code-cell}s
872d226
jb-article -> jb-book
9803c81
Adding more converted notebooks
7af90a1
Changing - to _ on adv3 filename
fa7fed3
Adding some of the newly converted notebooks to the toc
71f8a0b
Fix tabs in Makefile
stefanv ae4c3fe
Require book directory for building html
stefanv caea7c1
Fix incorrect build path
stefanv f18a5cd
website -> site
78a689b
website -> site
83728db
website -> site
d4325e7
Refactor the build system
stefanv 9edcefd
Fix skdemo
stefanv ef683cc
Fix up color_and_exposure module
stefanv f95be21
Fix image links
stefanv 28d0e4c
Fix notebooks; fix skdemo; fix notebook build path
stefanv 4103ab0
Require imagecodecs for reading tiffs
stefanv db180a5
Fix filters imports
stefanv 64cea04
threshold_adaptive is not threshold_local
stefanv bfcc8c5
Final fixes to adv0_chromosomes
stefanv ad248c4
Fix adv1_lesion_quantification
stefanv 6edeb56
Fix adv2_microarray
stefanv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ jobs: | |
python-version: [3.8] | ||
# TODO Uncomment when skimage theme is ready | ||
# node-version: [15] | ||
|
||
steps: | ||
- uses: actions/[email protected] | ||
|
||
|
@@ -60,17 +61,17 @@ jobs: | |
# - name: Build the theme | ||
# run: yarn build:theme-prod | ||
|
||
# Build the book | ||
- name: Build the book | ||
# Build site | ||
- name: Build site | ||
env: | ||
DISPLAY: ":99.0" | ||
run: jupyter-book build . | ||
run: make -C website/ html | ||
|
||
# Deploy the book's HTML to github pages | ||
# Deploy site to github pages | ||
- name: GitHub Pages action | ||
if: github.repository == 'scikit-image/skimage-tutorials' && github.ref == 'refs/heads/main' && github.event_name == 'push' | ||
uses: peaceiris/[email protected] | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
publish_dir: ./_build/html | ||
publish_dir: ./website/_build/html | ||
cname: scikit-image.org |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,6 @@ build | |
*~ | ||
*pano-advanced-output.png | ||
book/lessons | ||
|
||
# ignoring website local builds | ||
website/_build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
- file: lectures/00_images_are_arrays | ||
format: jb-article | ||
alexdesiqueira marked this conversation as resolved.
Show resolved
Hide resolved
|
||
root: lectures/00_images_are_arrays | ||
sections: | ||
- file: lectures/1_image_filters | ||
- file: lectures/3_morphological_operations | ||
- file: lectures/4_segmentation | ||
- file: lectures/three_dimensional_image_processing | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this move? I don't love it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt it'd make things more organized. I don't mind, though. Would you like me to leave it as it was?