Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add CPython 3.10 to testing #1808

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 10, 2022

Description

Resolves #1758

Now that PyTorch v1.11.0 is out with Python 3.10 support, we can add CPython 3.10 to the CI. A follow up PR will add Python 3.10 to the metadata.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add CPython 3.10 to the testing matrix in CI.
* Use CPython 3.10 as the default Python for all CI/CD workflows.

@matthewfeickert matthewfeickert added tests pytest CI CI systems, GitHub Actions labels Mar 10, 2022
@matthewfeickert matthewfeickert self-assigned this Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1808 (d1e0db1) into master (47ae6ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.02%     
==========================================
  Files          64       64              
  Lines        4270     4270              
  Branches      683      719      +36     
==========================================
+ Hits         4190     4191       +1     
  Misses         46       46              
+ Partials       34       33       -1     
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.60% <ø> (+0.02%) ⬆️
unittests 96.13% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/optimize/__init__.py 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ae6ad...d1e0db1. Read the comment docs.

@matthewfeickert
Copy link
Member Author

I'm going to merge this as adding additional CI testing probably isn't controversial, but I'm happy to have any follow up discussions or revert things as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 to CI
1 participant