Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python 3.10 support #334

Merged
merged 6 commits into from
Jul 30, 2022
Merged

feat: add Python 3.10 support #334

merged 6 commits into from
Jul 30, 2022

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Mar 11, 2022

Since pyhf now supports 3.10 (scikit-hep/pyhf#1808, scikit-hep/pyhf#1809), cabinetry should also officially support it. This adds the relevant metadata and adds Python 3.10 to the CI. See #277 for the corresponding PR that added Python 3.9 support.

This should only be merged after #301, which adds support for the upcoming pyhf 0.7 release.

* add Python 3.10 support and test Python 3.10 in CI
* updated pre-commit

@alexander-held alexander-held marked this pull request as draft March 11, 2022 09:33
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #334 (1c54744) into master (ba834d2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #334   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1876      1876           
  Branches       298       298           
=========================================
  Hits          1876      1876           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba834d2...1c54744. Read the comment docs.

@alexander-held alexander-held marked this pull request as ready for review March 11, 2022 10:46
@alexander-held alexander-held force-pushed the feat/python-310 branch 3 times, most recently from 98af20d to 536bf71 Compare March 11, 2022 15:28
@alexander-held alexander-held merged commit a237589 into master Jul 30, 2022
@alexander-held alexander-held deleted the feat/python-310 branch July 30, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant