Simple test for plain arrays serialization #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicate of #626 ? |
|
A bit. #626 Proposed more complete, but I have additional simple test for plain arrays. I can remove fix and propose test only |
scaytrase
force-pushed
the
bugfix/array-normalization
branch
from
6db2a00 to
4fad547
Compare
scaytrase
changed the title
|
what about the failing test? |
|
It would be fixed with #626, I think. That's the demonstration of the bug that currently present |
|
aaa, i see 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and fix sample
Add keys range check and remove string key requirement (numeric keys are ok for php plain arrays)