Fix serializing nulls in arrays

[megazoll]

nulls in the arrays should not be ignored when serializeNull is true.

[megazoll]

Also fixed yaml serialization for integrity and added some tests for serializing nulls

[goetas]

Merging this as it is is not possible. As it is, is a BC break since the array serialization behavior changes between versions.

What about adding an extra shouldSerializeInArrayNull ? this will make it BC compatible.

Other suggestions?

Otherwise will have to postpone it to 2.0

[scaytrase]

Not sure that fixing bug should be considered a BC break

[goetas]

Not sure that fixing bug should be considered a BC break

valid point....

[goetas]

But there will be a lot of broken code around if this gets merged as it is

[scaytrase]

The behaviour is inconsistent now. We have

$array = [0, null, 'a'];
$context = SerializationContext::create()->setSerializeNull(true);

Expression	var_dump result
$array	array(3) { [0] => int(0) [1] => NULL [2] => string(1) "a" }
$serializer->toArray($array)	array(2) { [0] => int(0) [1] => string(1) "a" }
json_encode($array)	string(12) "[0,null,"a"]"
serializer->serialize($array, 'json', $context)	string(15) "{"0":0,"2":"a"}"
Yaml::dump($array)	string(15) "- 0 - null - a "
serializer->serialize($array, 'yml', clone $context)	string(8) "- 0 - a "

[goetas]

@megazoll what do you think?

[goetas]

@scaytrase I agree with you, but Im just worried for all the users that upgrading from 1.3 to 1.4 get their code to be broken.

[scaytrase]

@goetas updated the table. Currently json makes the array to be an object, yaml does not (simply ignores null as toArray).

I think we should ask the community, i.e maintainers of some dependent libraries (FOS Rest, Sonata Admin)

https://www.versioneye.com/php/jms:serializer/references
https://www.versioneye.com/php/jms:serializer-bundle/references

[scaytrase]

IMO
It's not a BC break to have a major version. But we can aggregate more changes in a separate branch, leaving this one stable behind. Focusing on a separate major (and not upgrading this one) release we can introduce more usefull changes alongside the improving consistency.

[goetas]

At the moment moving it to 1.5

Anybody interested in implementing something as #626 (comment) ?

[megazoll]

@goetas updated. Please review my changes.

[goetas]

@megazoll Thanks for your effort, I have realized that this was an old standing bug (in XML was totally not working) and decided to fix it with #660 (as said is almost identical to the first version of your work).

Thanks again for the contribution and sorry if it took so much time and uncertainty.