Conversation
Fix cargo linter warning for a variable being unnecessarily mutable. Signed-off-by: Daniel Hodges <hodgesd@meta.com>
|
Hi, this once again broke scx_lavd, causing the same problem as #1482. This was fixed in #1483 by @multics69, by querying whether the file exists and trying the next possible file path. Removing the mut once again broke it. CC @JakeHillion |
|
I guess it needs a more proper fix like querying the tracefs mount. Maybe I'll move this helper into |
Hey, this specific change didn't break Nix. It's a no-op: Rust doesn't need this variable to be mutable because the match statement selects either the initial result or the second and places that into the variable. This means that the variable is not mutated after its initial assignment. For future reference, removing |
|
Right, I checked it myself, and it's still working, tested 8e33fa9 commit. I got a bug report from a user (@s0me1newithhand7s) on Telegram that lavd was broken, along with a cryptic error message "Error: No such file or directory (os error 2) https://gist.github.com/s0me1newithhand7s/fd3cf2b5d2c2262468972fb02129195d I am not sure what's going on here, as I can't reproduce it. But hopefully @s0me1newithhand7s can add more context. |
firstly: ~ 𝑠𝑛𝑜𝑤𝑦 𝑝𝑙𝑎𝑐𝑒, 𝑓𝑢𝑙𝑙 𝑜𝑓 𝑓𝑙𝑎𝑘𝑒𝑠!
╭──╼ s0mePC-nix on NixOS 25.5.0 ❄️
┆ ~
╰─> uname -a ✓ at ❗ 14:45
Linux s0mePC-nix 6.13.6-cachyos #1-NixOS SMP PREEMPT_DYNAMIC Fri Mar 7 17:27:16 UTC 2025 x86_64 GNU/Linuxso:
brief run of all other scheds resulted with no errors; i think this is some i can't really find any reasons why |
|
Right, you passed It should reach nixos-unstable in coming days. For now, you can reenable debugfs to use lavd properly. |
oh i see, tysm! |
|
@JohnRTitor -- FYI... The new refactoring on the previous fix creates a bug. And that bug was fixed a minute ago (#1506). |



Fix cargo linter warning for a variable being unnecessarily mutable.