Skip to content

scx_utils: Fix the failure in tracepoint_exists() in some kernel configs.#1483

Merged
multics69 merged 1 commit intosched-ext:mainfrom
multics69:utils-compat-fix-1482
Mar 10, 2025
Merged

scx_utils: Fix the failure in tracepoint_exists() in some kernel configs.#1483
multics69 merged 1 commit intosched-ext:mainfrom
multics69:utils-compat-fix-1482

Conversation

@multics69
Copy link
Contributor

tracepoint_exists() assumed that "/sys/kernel/tracing/available_events" always exists, which is not true in some kernel configurations. So let's check both "/sys/kernel/tracing/available_events" and "/sys/kernel/debug/tracing/available_events".

This fixes the following issue:
#1482

…igs.

tracepoint_exists() assumed that "/sys/kernel/tracing/available_events"
always exists, which is not true in some kernel configurations. So let's
check both "/sys/kernel/tracing/available_events" and
"/sys/kernel/debug/tracing/available_events".

This fixes the following issue:
  sched-ext#1482

Signed-off-by: Changwoo Min <changwoo@igalia.com>
@multics69 multics69 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into sched-ext:main with commit d25836a Mar 10, 2025
28 checks passed
@multics69 multics69 deleted the utils-compat-fix-1482 branch March 10, 2025 08:06
@JohnRTitor
Copy link
Contributor

Can we get this backported/made into a hotfix release since this bug makes scx_lavd unusable?

@multics69
Copy link
Contributor Author

Can we get this backported/made into a hotfix release since this bug makes scx_lavd unusable?

@JohnRTitor -- It seems okay in other distros (like CachyOS, Gentoo). Is there any way to include the fix in the nix package (I have almost zero knowledge on the nix packaging)?

@JohnRTitor
Copy link
Contributor

Done, thanks. We also enabled tracefs by default. So hopefully bugs like these won't bother again. NixOS/nixpkgs#388751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants