scx_utils: Fix the failure in tracepoint_exists() in some kernel configs.#1483
Merged
multics69 merged 1 commit intosched-ext:mainfrom Mar 10, 2025
Merged
Conversation
…igs. tracepoint_exists() assumed that "/sys/kernel/tracing/available_events" always exists, which is not true in some kernel configurations. So let's check both "/sys/kernel/tracing/available_events" and "/sys/kernel/debug/tracing/available_events". This fixes the following issue: sched-ext#1482 Signed-off-by: Changwoo Min <changwoo@igalia.com>
This was referenced Mar 10, 2025
arighi
approved these changes
Mar 10, 2025
Contributor
|
Can we get this backported/made into a hotfix release since this bug makes |
Contributor
Author
@JohnRTitor -- It seems okay in other distros (like CachyOS, Gentoo). Is there any way to include the fix in the nix package (I have almost zero knowledge on the nix packaging)? |
Contributor
|
Done, thanks. We also enabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracepoint_exists() assumed that "/sys/kernel/tracing/available_events" always exists, which is not true in some kernel configurations. So let's check both "/sys/kernel/tracing/available_events" and "/sys/kernel/debug/tracing/available_events".
This fixes the following issue:
#1482