-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUI proof of concept #481
Conversation
Thank you for the kind words!
I will see what I can do to make the implementation more generic :) |
…etAdjustmentBehavior
Thank you, @zntfdr. There is no problem to do that even after this PR. I'm looking forward to your improvements step by step. 😉 |
Thank you @scenee, I'm currently testing a generic implementation with my app (which uses 4 floating panels), and it seems to work great 😃 Once I complete the migration and documentation I will bring everything back in this PR 🙌🏻 |
Update: the implementation now is fully generic! |
I just took a look at the latest version. It looks so amazing!! I'm going to read your PR more closely later 😄 |
I found an issue that the surface view's layoutSubviews() isn't called around tip state. It looks SwiftUI issue because it doesn't occurs when the absolute inset of tip state is greater than 90. I think this issue doesn't block your PR and it's better to release this as beta version and blush up the implementation step by step. |
Thank you @scenee! |
@zntfdr Can I move your SwiftUI API code into the library? |
@zntfdr told me an issue on SwiftUI's environment propagation into FloatingPanel.
It's possible to lead behaviors unexpected by SwiftUI users so that I will merge this PR as a sample code. |
have we fully supported SwiftUI now, or it is still just POC? |
SwfitUI APIs are still PoC because we acknowledge there are some issues depending on SwiftUI. |
Partially solves #281.
This PR adds a new example app which mimics the Maps.app, written in SwiftUI.
The code works for iOS 13+, however:
If it's ok, I will leave this PR as a draft until Xcode 13 is released.
In the meanwhile, I'm happy to receive any feedback you might have 😃