Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance scroll view handling #2

Merged
merged 20 commits into from
Oct 23, 2018
Merged

Enhance scroll view handling #2

merged 20 commits into from
Oct 23, 2018

Conversation

scenee
Copy link
Owner

@scenee scenee commented Oct 20, 2018 •
edited
Loading 

+ FloatingPanelController.adjustedContentInsets
+ FloatingPanelController.contentInsetAdjustmentBehavior
  • Changed API
- FloatingPanelController.add(toParent:belowView:animated)
+ FloatingPanelController.addPanel(toParent:belowView:animated)
- FloatingPanelController.removeFromParent(animated:completion:)
+ FloatingPanelController.removePanelFromParent(animated:completion:)
  • Improve scroll view tracking
    • Projecting a content scrolling to the panel moving smoothly
    • Lock & unlock a scroll view
  • Fix backdrop layout and behavior bugs
  • Fix bugs on iOS10
  • Add Samples app
  • Improve Fluid behavior

@scenee scenee changed the title Enhance scroll view tracking Enhance scroll view handling Oct 20, 2018
@scenee scenee force-pushed the enhance-scroll-view-tracking branch 2 times, most recently from 339b2de to 6165121 Compare October 20, 2018 16:02
scenee added 5 commits October 21, 2018 10:19
@scenee
Improve scroll view tracking
7c3581d 
- Improve locking/unlocking scroll view to prevent scroll bouncing
and showing a scroll indicator unexpectedly.
- Handle scrollview.panGestureRecognizer change
- Handle scrollView.delegate intermediately.
@scenee
Fix FloatingPanelController.removeFromParent() on iOS10
ce556e2
@scenee
Fix FloatingPanel.safeAreaInsets on iOS10
a3e8d15
@scenee
Fix a backdrop bug
4e2f9bc
@scenee
Modify API names to add/remove a floating panel
ad46f5b
@scenee scenee force-pushed the enhance-scroll-view-tracking branch 7 times, most recently from 242bcdd to e8c651d Compare October 22, 2018 09:15
@scenee scenee force-pushed the enhance-scroll-view-tracking branch from e8c651d to 868dc17 Compare October 23, 2018 00:53
@scenee scenee merged commit e620ef2 into master Oct 23, 2018
@scenee scenee deleted the enhance-scroll-view-tracking branch October 23, 2018 23:14
@Isuru-Nanayakkara Isuru-Nanayakkara mentioned this pull request May 23, 2019
Closed
3 tasks
dscyrescotti pushed a commit to dscyrescotti/FloatingPanel that referenced this pull request Jun 16, 2022
@scenee
Merge pull request scenee#2 from SCENEE/enhance-scroll-view-tracking
b080609 
Enhance scroll view handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to scroll to last item on TableView
1 participant
@scenee