Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION [PR#1916 > development/8.1] ARSN-212 remove assert in decoder in favor of returning an error. #1919

Merged

Conversation

bert-e
Copy link
Contributor

@bert-e bert-e commented May 20, 2022

This pull request has been created automatically.
It is linked to its parent pull request #1916.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.1/bugfix/ARSN-212-remove-assert-in-decoder, please follow this
procedure:

 $ git fetch
 $ git checkout w/8.1/bugfix/ARSN-212-remove-assert-in-decoder
 $ # <amend or cancel the changeset by _adding_ new commits>
 $ git push origin w/8.1/bugfix/ARSN-212-remove-assert-in-decoder

Please always comment pull request #1916 instead of this one.

@codecov-commenter
Copy link

Codecov Report

Merging #1919 (d7df1df) into development/8.1 (f59b1b5) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@                 Coverage Diff                 @@
##           development/8.1    #1919      +/-   ##
===================================================
- Coverage            63.27%   63.26%   -0.01%     
===================================================
  Files                  204      204              
  Lines                15512    15511       -1     
  Branches              3096     3096              
===================================================
- Hits                  9815     9813       -2     
- Misses                5682     5683       +1     
  Partials                15       15              
Impacted Files Coverage Δ
lib/versioning/VersionID.ts 93.81% <75.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59b1b5...d7df1df. Read the comment docs.

@bert-e bert-e merged commit d7df1df into development/8.1 May 20, 2022
@bert-e bert-e deleted the w/8.1/bugfix/ARSN-212-remove-assert-in-decoder branch May 20, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants