Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-212 remove assert in decoder in favor of returning an error. #1916

Merged
merged 1 commit into from
May 20, 2022

Conversation

watsaqat
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented May 19, 2022

Hello watsaqat,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 19, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-212 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.25

  • 8.1.49

Please check the Fix Version/s of ARSN-212, or the target
branch of this pull request.

@watsaqat
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented May 19, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented May 19, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@watsaqat watsaqat force-pushed the bugfix/ARSN-212-remove-assert-in-decoder branch from 7d13749 to 3f26b43 Compare May 19, 2022 23:27
@bert-e
Copy link
Contributor

bert-e commented May 19, 2022

History mismatch

Merge commit #5616133722d962594e1057c9c6c3661fbea3d0b7 on the integration branch
w/8.1/bugfix/ARSN-212-remove-assert-in-decoder is merging a branch which is neither the current
branch bugfix/ARSN-212-remove-assert-in-decoder nor the development branch
development/8.1.

It is likely due to a rebase of the branch bugfix/ARSN-212-remove-assert-in-decoder and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@watsaqat
Copy link
Contributor Author

/reset

@watsaqat
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 20, 2022

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented May 20, 2022

Incorrect fix version

The Fix Version/s in issue ARSN-212 contains:

  • 7.10.3.6

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.25

  • 8.1.49

Please check the Fix Version/s of ARSN-212, or the target
branch of this pull request.

The following options are set: approve

@watsaqat
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented May 20, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: approve

@scality scality deleted a comment from bert-e May 20, 2022
@bert-e
Copy link
Contributor

bert-e commented May 20, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 20, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.4

Please check the status of the associated issue ARSN-212.

Goodbye watsaqat.

@bert-e bert-e merged commit 3f26b43 into development/7.10 May 20, 2022
@bert-e bert-e deleted the bugfix/ARSN-212-remove-assert-in-decoder branch May 20, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants