-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new component SelectableCardOptionGroup #4798
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 81ddac8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8cfdab5
to
5ebd409
Compare
5ebd409
to
3b9f363
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
+ Coverage 89.19% 89.25% +0.05%
==========================================
Files 230 235 +5
Lines 8009 8115 +106
Branches 3680 3732 +52
==========================================
+ Hits 7144 7243 +99
- Misses 865 872 +7
Continue to review full report in Codecov by Sentry.
|
Summary
Type
New component
SelectableCardOptionGroup
✨<Popup />
: fix when there is no animation to not add asetTimeout
to close the popup. This will improve the behavior of<SelectInputV2 />
and make the testing less random.<SelectableCard />
: remove pointer events on the radio. We were already doing it with the checkbox version. Also improved tabulation to be more accessible.<Label />
: improve component to acceptas
prop that can take eitherlabel
orlegend
. It also acceptsentiment
anddisabled
props now. The mouse pointer will be a pointer as well whenhtmlFor
is passed.<SelectInputV2 />
: improve the focusable elements and fix a visual bug to double click to open the dropdown. Also when there is no space in the input the text will be ellipsis.<SelectableCardOptionGroup />
<SelectableCardOptionGroupField />
Relevant logs and/or screenshots