Skip to content

fix: attach volume key choice #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuentinBrosse merged 2 commits into from
Sep 16, 2019
Merged

fix: attach volume key choice #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5182c48
fix: attach volume key choice
Sh4d1 Sep 16, 2019
2e4bfc4
typo comment
QuentinBrosse Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions api/instance/v1/instance_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,25 @@ func (s *API) AttachVolume(req *AttachVolumeRequest, opts ...scw.RequestOption)
newVolumes := volumesToVolumeTemplates(volumes)

// add volume to volumes list
key := fmt.Sprintf("%d", len(volumes))
newVolumes[key] = &VolumeTemplate{
ID: req.VolumeID,
// name is ignored on this PATCH
Name: req.VolumeID,
// We loop through all the possible volume keys (0 to len(volumes))
// to find a non existing key and assign it to the requested volume.
// A key should always be found. However we return an error if no keys were found.
found := false
for i := 0; i <= len(volumes); i++ {
key := fmt.Sprintf("%d", i)
if _, ok := newVolumes[key]; !ok {
newVolumes[key] = &VolumeTemplate{
ID: req.VolumeID,
// name is ignored on this PATCH
Name: req.VolumeID,
}
found = true
break
}
}

if !found {
return nil, fmt.Errorf("could not find key to attach volume %s", req.VolumeID)
}

// update server
Expand Down