fix: attach volume key choice #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBrosse
suggested changes
Sep 16, 2019
Signed-off-by: Patrik Cyvoct <[email protected]>
Sh4d1
force-pushed
the
fix_attach_volumes
branch
from
5d20d9a to
5182c48
Compare
QuentinBrosse
approved these changes
Sep 16, 2019
Contributor
QuentinBrosse
left a comment
QuentinBrosse
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contribution! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when attaching a volume, the sdk attach it to the ID that is the len of the volume list. Unfortunately, if the list is
0, 1, 2and the volume1is removed, the list becomes0, 2. This leads to a newly attached volumes to be attached to the ID2, thus overriding the already existing volume. This fix this issue by looping over all the keys, and attaching to a non existent key.Signed-off-by: Patrik Cyvoct [email protected]