-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Unignore tests after backporting #6015
Conversation
Ach, I think because I broke master, we didn't get a new nightly last night. |
"3.3.2" -> """|using (commit: '') | ||
|unsafeExceptions scala (commit: '') | ||
|unchecked scala (commit: '') | ||
|unsafe - caps (commit: '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|unsafe - caps (commit: '') | |
|unsafe - caps (commit: '') |
Scala is not printed here, there is a specific logic in the printer that is hard to make work and is working fine with the presentation compiler module itselg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't managed to fix all tagged with IgnoreForScala3CompilerPC, if anyone has time it would be worth looking if maybe we missed backporting something.
@@ -568,7 +564,7 @@ class SyntheticDecorationsSuite extends BaseSyntheticDecorationsSuite { | |||
) | |||
|
|||
check( | |||
"val-def-with-bind", | |||
"val-def-with-bind".tag(IgnoreForScala3CompilerPC), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkciesluk didn't you fix this, maybe it wasn't backported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was fixed in #5891, we probably didn't backport it
No description provided.