bugfix: don't show inferred type for val def bind #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
val-with-@-decorations
branch
from
c8cb490
to
7ac55b5
Compare
kasiaMarek
force-pushed
the
val-with-@-decorations
branch
from
7ac55b5
to
32323c8
Compare
jkciesluk
approved these changes
Nov 30, 2023
| * val <<t>> @ ... = | ||
| */ | ||
| private def isValDefBind(vd: ValDef)(using Context) = | ||
| val (_, afterDef) = vd.source.content().splitAt(vd.nameSpan.end) |
There was a problem hiding this comment.
Suggested change
| val (_, afterDef) = vd.source.content().splitAt(vd.nameSpan.end) | |
| val afterDef = text.drop(vd.namePosition.end) |
| * val <<t>> @ ... = | ||
| */ | ||
| private def isValDefBind(vd: ValDef) = { | ||
| val (_, afterDef) = vd.pos.source.content.splitAt(vd.namePosition.end) |
There was a problem hiding this comment.
Maybe we can move it to PcSyntheticDecorationsProvider so we can use text instead of pos.source.content?
There was a problem hiding this comment.
I don't want to move it for Scala 3, I'd have to pattern match to see it's a ValDef, and it's a bit inconsistent. I added a given for Scala 3 instead (with an opaque type). What do you think? Too much hassle?
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Jan 17, 2024
Backports changes from - scalameta/metals#5891 - scalameta/metals#5982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5835
There seems to be no reasonable way to distinguish
tfromt1inval t @ (t1, t2,) = (1,2)in typed trees. We could do this on untyped but I think it will be faster this way.