Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Projects,Teams,TaskTypes with name suffix to allow reusing names #7573

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Delete Projects,Teams,TaskTypes with name suffix to allow reusing names #7573

merged 9 commits into from
Jan 24, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 22, 2024 •
edited
Loading

Allow re-using names of projects, teams, tasktypes after deleting them.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create some projects, teams, tasktypes, delete them, create new with the same name

TODOs:

  • discuss if we need a special char as delimiter

Issues:

@fm3 fm3 self-assigned this Jan 22, 2024
@fm3 fm3 changed the title WIP: Delete Projects,Teams,TaskTypes with name suffix to allow reusing names Delete Projects,Teams,TaskTypes with name suffix to allow reusing names Jan 22, 2024
@fm3 fm3 marked this pull request as ready for review January 22, 2024 12:45
@fm3 fm3 requested a review from frcroth January 22, 2024 13:49
frcroth
frcroth approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup issue for deleting datasets?

@fm3
Copy link
Member Author

fm3 commented Jan 22, 2024

Followup issue for deleting datasets?

Part of #6613 I’d say

For datasets this is harder since they are referenced by name in tracing proto objects in FossilDB

@fm3
Copy link
Member Author

fm3 commented Jan 23, 2024

@frcroth I decided to add an SQL migration to rename all previously deleted projects,teams and tasktypes to free up their names too. Could you have another look please?

@fm3 fm3 requested a review from frcroth January 23, 2024 08:31
@fm3 fm3 mentioned this pull request Jan 23, 2024
Closed
@fm3 fm3 merged commit cddab30 into master Jan 24, 2024
2 checks passed
@fm3 fm3 deleted the reuse-team-names branch January 24, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frcroth frcroth frcroth approved these changes

Assignees

@fm3 fm3

Labels
backend new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow re-using names of deleted entities
2 participants
@fm3 @frcroth