-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize list focus with active segment #7512
Synchronize list focus with active segment #7512
Conversation
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
Outdated
Show resolved
Hide resolved
@philippotto I decided that a multiselection of segment should not be overwritten by a click on a segment. Because both the context menu entry and the segment click are causing the same action, the context menu entry doesnt overwrite it either. Thats probably counterintuitive. Obviously I could build around that, but I just wanted to make sure that we are keeping both ways to focus the segment :) So we are keeping the context menu entry and the click, right? Or should I ask for more opinions first? |
there may be edge cases where this context menu entry is displayed although it doesnt make sense, but I think that applies for more than this context menu entry. see #7538. I didnt know what edge exactly I found, but if its easy I will of course fix it in this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff :) I left some feedback, but overall it's already looking pretty good 👍
frontend/javascripts/oxalis/model/actions/volumetracing_actions.ts
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx
Outdated
Show resolved
Hide resolved
* drag selected segments as well as the dragged segment * add comment * add changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me :)
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
jump to segment
andSelect segment
in viewport segment dropdownthis.tree.current.scrollTo({ key: selectedElement.key });
with the key beingsegment-<id>
-> may be bug
Issues:
(Please delete unneeded items, merge only when none are left open)