Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi segment drag and drop #7536

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jan 9, 2024

fixes #7527

Steps to test:

  • Go to segments tab and play around with drag and drop.
  • Explore the following cases:
    • No segment is selected
    • Multiple segments are selected
    • One segment is selected
    • Selected segment is dragged
    • Not selected segment is dragged

@dieknolle3333 dieknolle3333 self-assigned this Jan 9, 2024
@dieknolle3333 dieknolle3333 changed the title Fix multi segment drop Add multi segment drag and drop Jan 9, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review January 9, 2024 18:25
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :)

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) January 15, 2024 09:30
@dieknolle3333 dieknolle3333 merged commit b60dc9d into master Jan 15, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the fix-multi-segment-drop branch January 15, 2024 09:54
dieknolle3333 added a commit that referenced this pull request Jan 15, 2024
* drag selected segments as well as the dragged segment

* add comment

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support drag and drop of multiple segments
2 participants