Added new drawings to job notification emails #6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il-images * 'master' of github.com:scalableminds/webknossos: Fix handling underscores in GCS bucket name (#6998)
philippotto
reviewed
Apr 21, 2023
| @@ -26,4 +26,11 @@ | |||
| </div> | |||
|
|
|||
| <p>With best regards,<br />the WEBKNOSSOS team</p> | |||
|
|
|||
| <div style="text-align: center;"> | |||
| <img src="https://static.webknossos.org/mails/email-drawing-successful-job.png" | |||
There was a problem hiding this comment.
I get an access denied message for this url.
philippotto
reviewed
Apr 21, 2023
| @@ -31,6 +31,17 @@ | |||
| <p> | |||
| Did you know that we offer services for <a href="https://webknossos.org/services/alignment">dataset alignment & stitching</a> and <a href="https://webknossos.org/services/automated-segmentation">AI image segmentation</a> to kickstart your research? | |||
| </p> | |||
| <div style="text-align: center; margin-top: 10px; margin-bottom: 6px;"> | |||
There was a problem hiding this comment.
unrelated to this pr, but in line 9 of this file, it says amongst your other dataset but it should be datasetS.
philippotto
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds new drawings to job notification emails in accordance with new branding.
URL of deployed dev instance (used for testing):
Steps to test:
Successful Upload
Failed Job (Generic)
Successful Job (Generic)
Issues:
(Please delete unneeded items, merge only when none are left open)