Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding #6739

Merged
merged 14 commits into from
Jan 17, 2023
Merged

Rebranding #6739

merged 14 commits into from
Jan 17, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 13, 2023

  • Adds the new WEBKNOSSOS logo
  • Changes the primary color to #5660FF
  • Changes brand name from webKnossos to WEBKNOSSOS

URL of deployed dev instance (used for testing):

Steps to test:


(Please delete unneeded items, merge only when none are left open)

@normanrz normanrz self-assigned this Jan 13, 2023
@fm3
Copy link
Member

fm3 commented Jan 13, 2023

Favicon seems to be #6456ff, not #5660FF, is that intended?

@normanrz
Copy link
Member Author

Favicon seems to be #6456ff, not #5660FF, is that intended?

That shouldn't be the case. Where are you seeing that?

@jstriebel
Copy link
Contributor

Just found this gray text which I found hard to read in dark-mode, it's okayish in light-mode (might not even be affected by the new colors):
Screenshot from 2023-01-13 13-34-39
Screenshot from 2023-01-13 13-37-09

@jstriebel
Copy link
Contributor

I'm not quite sure if Nunito is used correctly, I couldn't find it in the sources. Maybe move it to fonts, next to the Titilium woff2 files?

@fm3
Copy link
Member

fm3 commented Jan 13, 2023

Where are you seeing that?

image

(favicon purple-ish, big svg bluer)

@philippotto
Copy link
Member

Regarding the new font: it still doesn't seem to be used on my machine. Or is this expected?

image

@normanrz
Copy link
Member Author

For me it loads and uses the network font, now.
Screenshot 2023-01-13 at 15 08 00

@philippotto
Copy link
Member

Now it works 👍 Maybe it was a caching issue.

@philippotto
Copy link
Member

I found some spots where old colors are still used:

  • in the dataset folder view the left sidebar's background is still the old blue when dragging a dataset
  • the active entries in the tree list and segment list view in an annotation

The rest is looking good 👍

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍 The new look feels like home already.

The only thing I noticed is that the margins now seem different for multi-line tags. Not sure which change caused this but on master, this doesn't seem to be the case:

image

new vs vs

image

But this doesn't need to block the PR in my opinion.

@normanrz
Copy link
Member Author

The only thing I noticed is that the margins now seem different for multi-line tags. Not sure which change caused this but on master, this doesn't seem to be the case:

image

new vs vs

image

But this doesn't need to block the PR in my opinion.

How about this?
Screenshot 2023-01-17 at 09 45 03

@philippotto
Copy link
Member

How about this?

Yes, this looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants