Add email notifications for processing jobs #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
reviewed
Mar 20, 2023
| @emailBaseTemplate() { | ||
| <p>Hi @{name},</p> | ||
|
|
||
| <p>We wanted to let you know that WEBKNOSSOS has finished your background job for the dataset <i>@{datasetName}</i>. |
There was a problem hiding this comment.
"We wanted to let you know that" could be removed in my opinion as it doesn't add much value.
| border-radius: 4px; | ||
| display: inline-block; | ||
| "> | ||
| Click here to open |
There was a problem hiding this comment.
open what? also, "click here" could be removed probably. maybe just "View results"?
| <p>Hi @{name},</p> | ||
|
|
||
| <p> | ||
| oops, something went unexpected wrong when uploading and converting your dataset <i>@{datasetName}</i> for WEBKNOSSOS. |
There was a problem hiding this comment.
Maybe something like "unfortunately, your uploaded dataset could not be converted automatically for WEBKNOSSOS" would sound a bit more professional?
| <p>Hi @{name},</p> | ||
|
|
||
| <p> | ||
| oops, something unexpected went wrong when working on your WEBKNOSSOS @{jobTitle} job for the <i>@{datasetName}</i> dataset. |
There was a problem hiding this comment.
Suggested change
| oops, something unexpected went wrong when working on your WEBKNOSSOS @{jobTitle} job for the <i>@{datasetName}</i> dataset. | |
| oops, something unexpected went wrong when executing your WEBKNOSSOS @{jobTitle} job for the <i>@{datasetName}</i> dataset. |
fm3
reviewed
Mar 20, 2023
app/models/job/JobCommand.scala
Outdated
Comment on lines
8
to
15
| val COMPUTE_MESH_FILE = Value("compute_mesh_file") | ||
| val CONVERT_TO_WKW = Value("convert_to_wkw") | ||
| val EXPORT_TIFF = Value("export_tiff") | ||
| val FIND_LARGEST_SEGMENT_ID = Value("find_largest_segment_id") | ||
| val GLOBALIZE_FLOODFILLS = Value("globalize_floodfills") | ||
| val INFER_NUCLEI = Value("infer_nuclei") | ||
| val INFER_NEURONS = Value("infer_neurons") | ||
| val MATERIALIZE_VOLUME_ANNOTATION = Value("materialize_volume_annotation") |
There was a problem hiding this comment.
Suggested change
| val COMPUTE_MESH_FILE = Value("compute_mesh_file") | |
| val CONVERT_TO_WKW = Value("convert_to_wkw") | |
| val EXPORT_TIFF = Value("export_tiff") | |
| val FIND_LARGEST_SEGMENT_ID = Value("find_largest_segment_id") | |
| val GLOBALIZE_FLOODFILLS = Value("globalize_floodfills") | |
| val INFER_NUCLEI = Value("infer_nuclei") | |
| val INFER_NEURONS = Value("infer_neurons") | |
| val MATERIALIZE_VOLUME_ANNOTATION = Value("materialize_volume_annotation") | |
| val compute_mesh_file, convert_to_wkw, export_tiff, find_largest_segment_id, globalize_floodfills, infer_nuclei, infer_neurons, materialize_volume_annotation = Value |
…sos into email-notification * 'email-notification' of github.com:scalableminds/webknossos: Update app/views/mail/jobSuccessfulSegmentation.scala.html Update PULL_REQUEST_TEMPLATE.md
…il-notification * 'master' of github.com:scalableminds/webknossos: Update screenshots (#6934) Support rendering negative floats (#6895) Fix loading of webworkers in dev mode (#6933) Restore cache buster for webworkers (#6932) Introduce data vault as storage backend abstraction (#6899) Fix download button for annotations when tiff export is disabled (#6931)
…sos into email-notification * 'email-notification' of github.com:scalableminds/webknossos:
|
@philippotto @fm3 I added your PR feedback |
philippotto
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds email notifications for long running WEBKNOSSOS worker jobs. The PR also adds a new API route for downloading Tiffs that does not require a user token (but handles authentication internally). This URI can easily be shared through email without "exposing" a user token.
Jobs with email notifications:
Jobs without email notifications:
Design Doc
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
### Requires WK worker update on deployment. See accompanying worker PR https://github.com/scalableminds/voxelytics/pull/3245(Please delete unneeded items, merge only when none are left open)