Skip to content

Fix styling for login pages for dark mode users #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 14, 2023

This PR fixes some styling issues for dark mode users after logging out. The default theme for WEBKNOSSOS is light, especially when logged out. This fix, restores light mode on each log out to fix the UI. Theme switching in this case is not persisted as a user choice, though, in order to return to dark mode on the next login for dark mode users.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  1. Log in
  2. Switch to dark mode
  3. Log out.
  4. Login page should look correct, i.e. have hints for each input field
  5. Log in again. You should be in dark mode once more.

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Mar 14, 2023
@hotzenklotz hotzenklotz requested a review from philippotto March 14, 2023 08:31
@philippotto
Copy link
Member

This PR fixes some styling issues for dark mode users after logging out.

In Firefox, I have the styling problem simply by opening the log in page (without having logged in before). See screenshot. I think, the problem is that the default theme is "auto" and my Firefox uses a dark theme which then propagates to wK using the dark theme.

Maybe it would be easier to give the entire log in view a css class à la "light-container" and then override the input color via .light-container { input { color: black; } } or something like that. With the current approach I would also suspect that logging out and directly logging in again could lose the theme setting (not tested, though).

image

…_login_styles

* 'master' of github.com:scalableminds/webknossos:
  Release 23.03.1 (#6917)
  Redesign Welcome UI (#6904)
…x_login_styles

* 'master' of github.com:scalableminds/webknossos:
  Added members to admin team page (#6915)
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) March 15, 2023 08:59
@hotzenklotz hotzenklotz merged commit f9faf62 into master Mar 15, 2023
@hotzenklotz hotzenklotz deleted the fix_login_styles branch March 15, 2023 09:05
hotzenklotz added a commit that referenced this pull request Mar 15, 2023
…il-notification

* 'master' of github.com:scalableminds/webknossos:
  Fix styling for login pages for dark mode users (#6916)
  Added members to admin team page (#6915)
hotzenklotz added a commit that referenced this pull request Mar 20, 2023
…pdown-menu

* 'master' of github.com:scalableminds/webknossos:
  Fix download button for annotations when tiff export is disabled (#6931)
  Update PULL_REQUEST_TEMPLATE.md
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
  Fix styling for login pages for dark mode users (#6916)
  Added members to admin team page (#6915)
  Release 23.03.1 (#6917)
  Redesign Welcome UI (#6904)
  Fix race condition which could disable saving (#6914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Screen has no input hints in dark mode
2 participants