-
Notifications
You must be signed in to change notification settings - Fork 27
Fix styling for login pages for dark mode users #6916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Firefox, I have the styling problem simply by opening the log in page (without having logged in before). See screenshot. I think, the problem is that the default theme is "auto" and my Firefox uses a dark theme which then propagates to wK using the dark theme. Maybe it would be easier to give the entire log in view a css class à la "light-container" and then override the input color via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…pdown-menu * 'master' of github.com:scalableminds/webknossos: Fix download button for annotations when tiff export is disabled (#6931) Update PULL_REQUEST_TEMPLATE.md Prepare multi modality support (#6748) Improvements for terms-of-services modal (#6930) Fix creating task types with preferred mode (#6928) Fix styling for login pages for dark mode users (#6916) Added members to admin team page (#6915) Release 23.03.1 (#6917) Redesign Welcome UI (#6904) Fix race condition which could disable saving (#6914)
This PR fixes some styling issues for dark mode users after logging out. The default theme for WEBKNOSSOS is light, especially when logged out. This fix, restores light mode on each log out to fix the UI. Theme switching in this case is not persisted as a user choice, though, in order to return to dark mode on the next login for dark mode users.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)