Fix race condition which could disable saving #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e could mean that changes were never saved)
philippotto
commented
Mar 13, 2023
| @@ -249,6 +250,7 @@ export function* acquireAnnotationMutexMaybe(): Saga<void> { | |||
| while (shallTryAcquireMutex) { | |||
| if (isInitialRequest) { | |||
| yield* put(setAnnotationAllowUpdateAction(false)); | |||
| yield* call(sleep, 5000); | |||
There was a problem hiding this comment.
revert 37692e7 before merging.
daniel-wer
approved these changes
Mar 13, 2023
Co-authored-by: Daniel <[email protected]>
This reverts commit 37692e7.
Merged
hotzenklotz
added a commit
that referenced
this pull request
Mar 20, 2023
…pdown-menu * 'master' of github.com:scalableminds/webknossos: Fix download button for annotations when tiff export is disabled (#6931) Update PULL_REQUEST_TEMPLATE.md Prepare multi modality support (#6748) Improvements for terms-of-services modal (#6930) Fix creating task types with preferred mode (#6928) Fix styling for login pages for dark mode users (#6916) Added members to admin team page (#6915) Release 23.03.1 (#6917) Redesign Welcome UI (#6904) Fix race condition which could disable saving (#6914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition which would affect saving when annotation-sharing was activated. Especially on slow computers, this could lead to a faulty initialization which would mean that nothing was saved.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)