Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license checker #6715

Merged
merged 3 commits into from
Jan 3, 2023
Merged

add license checker #6715

merged 3 commits into from
Jan 3, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 2, 2023

Adds a license checker for the backend. It can be run with sbt dumpLicenseReport (not sure where to document this). The frontend already has that in the form of yarn licenses ls.


  • Ready for review

@normanrz normanrz requested a review from fm3 January 2, 2023 17:08
@normanrz normanrz self-assigned this Jan 2, 2023
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the development commands are defined in package.json (even those that in turn call sbt) – maybe that would be a good place to “document” this? Otherwise, we could start a more generalized readme markdown file for development, or start a list in notion with such commands. There is also the public webknossos wiki, but I think it is becoming disused 😬

@bulldozer-boy bulldozer-boy bot merged commit d3ea26f into master Jan 3, 2023
@bulldozer-boy bulldozer-boy bot deleted the licne branch January 3, 2023 09:01
hotzenklotz added a commit that referenced this pull request Jan 5, 2023
…cing

* 'master' of github.com:scalableminds/webknossos:
  Replace babel with esbuild for tests and for webpack (#6527)
  Use less ram when initializing data textures (#6711)
  Composable sql interpolation (#6718)
  Release 23.01.0 (#6717)
  add license checker (#6715)
  Fix brush performance for coarse mags & avoid some unnecessary re-renders (#6708)
  Change backend format command (#6697)
  Improve layout of terms of services check (#6712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants