Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brush performance for coarse mags & avoid some unnecessary re-renders #6708

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Fix brush performance for coarse mags & avoid some unnecessary re-renders #6708

merged 8 commits into from
Dec 21, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Dec 20, 2022 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • brush in a dataset at mag 512 (needs resolution restriction during setup) --> performance should be similar to brushing in mag 1
  • activate react devtools and check that the toolbar doesn't re-render constantly on mouse move

Issues:

  • perf perf perf

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Dec 20, 2022
daniel-wer
daniel-wer approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that you found the culprit! Also, great additional fixes 👍

If it's easy to do you could also fix that the brush size in the brush size popover is cut off after three or four digits (and displayed as a .0 float), but no blocker for this PR.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
frontend/javascripts/libs/drawing.ts Show resolved Hide resolved
@philippotto philippotto enabled auto-merge (squash) December 21, 2022 15:07
@philippotto philippotto merged commit 53a4027 into master Dec 21, 2022
@philippotto philippotto deleted the fix-brush-perf branch December 21, 2022 15:32
hotzenklotz added a commit that referenced this pull request Jan 5, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into pri…
f1e34ac 
…cing

* 'master' of github.com:scalableminds/webknossos:
  Replace babel with esbuild for tests and for webpack (#6527)
  Use less ram when initializing data textures (#6711)
  Composable sql interpolation (#6718)
  Release 23.01.0 (#6717)
  add license checker (#6715)
  Fix brush performance for coarse mags & avoid some unnecessary re-renders (#6708)
  Change backend format command (#6697)
  Improve layout of terms of services check (#6712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer