Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode layer visibility in sharing link #6634

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Encode layer visibility in sharing link #6634

merged 5 commits into from
Nov 14, 2022

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 10, 2022 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • Open an annotation, enable and disable layers, set the annotation to public and copy the sharing link
    • Open the annotation in an incognito tab, the layer visibility should be equal to the original annotation (also for the Skeleton layer)
    • Reload the original annotation, the layer visibility should remain the same

Issues:

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Nov 10, 2022
philippotto
philippotto reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍 However, during testing I got the following toast when opening the sharing link:

URL configuration values for the layer "color" are ignored, because: The requested layer with name color is not a segmentation layer.

This should probably not happen, right?

The visibility was correct for my layers, though. It was a public annotation for a private dataset with with a visible color layer, invisible volume layer and visible skeleton layer. I'll share the link with you privately.

@daniel-wer
Copy link
Member Author

However, during testing I got the following toast when opening the sharing link:

URL configuration values for the layer "color" are ignored, because: The requested layer with name color is not a segmentation layer.

This should probably not happen, right?

Uh, good job catching that 🙈 Fixed in the newest version.

philippotto
philippotto approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works for me now 👍

@bulldozer-boy bulldozer-boy bot merged commit 7c62974 into master Nov 14, 2022
@bulldozer-boy bulldozer-boy bot deleted the share-layer-visibility branch November 14, 2022 13:58
hotzenklotz added a commit that referenced this pull request Nov 15, 2022
@hotzenklotz
Merge branches 'pricing' and 'master' of github.com:scalableminds/web…
ad03de9 
…knossos into pricing

* 'pricing' of github.com:scalableminds/webknossos:
* 'master' of github.com:scalableminds/webknossos:
  Release 22.11.2 (#6629)
  Encode layer visibility in sharing link (#6634)
  Allow viewing vx workflows via link if organization matches (#6622)
  Hotfix: increase zarr chunk cache size (#6639)
  Integrate Rome Linting (#6618)
  Fix task creation with base NML (#6635)
  Fix NGFF import for datasets with no channel axis (#6637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@daniel-wer daniel-wer

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-wer @philippotto