Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow viewing vx workflows via link if organization matches #6622

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Allow viewing vx workflows via link if organization matches #6622

merged 2 commits into from
Nov 14, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Nov 9, 2022

URL of deployed dev instance (used for testing):

Steps to test:

  • Run vx workflow, reporting to this instance
  • You should be able to see and list the workflow
  • Another user in the same orga should see via link but not list the workflow

Issues:

@fm3 fm3 requested a review from normanrz November 9, 2022 15:03
@fm3 fm3 self-assigned this Nov 9, 2022
@fm3 fm3 requested a review from jstriebel November 14, 2022 12:38
jstriebel
jstriebel approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 enabled auto-merge (squash) November 14, 2022 13:16
@fm3 fm3 merged commit 46f8eee into master Nov 14, 2022
@fm3 fm3 deleted the vx-unlisted branch November 14, 2022 13:36
hotzenklotz added a commit that referenced this pull request Nov 15, 2022
@hotzenklotz
Merge branches 'pricing' and 'master' of github.com:scalableminds/web…
ad03de9 
…knossos into pricing

* 'pricing' of github.com:scalableminds/webknossos:
* 'master' of github.com:scalableminds/webknossos:
  Release 22.11.2 (#6629)
  Encode layer visibility in sharing link (#6634)
  Allow viewing vx workflows via link if organization matches (#6622)
  Hotfix: increase zarr chunk cache size (#6639)
  Integrate Rome Linting (#6618)
  Fix task creation with base NML (#6635)
  Fix NGFF import for datasets with no channel axis (#6637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@normanrz normanrz Awaiting requested review from normanrz

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voxelytics reports should be viewable for anyone in the right orga who has the link
2 participants
@fm3 @jstriebel