Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-Auth Tokens everywhere (in datastore & tracingstore) #6312

Merged
merged 5 commits into from
Jun 30, 2022
Merged

X-Auth Tokens everywhere (in datastore & tracingstore) #6312

merged 5 commits into from
Jun 30, 2022

Conversation

leowe
Copy link
Contributor

@leowe leowe commented Jun 30, 2022 •
edited
Loading

  • add urlTokenOrHeader to all relevant endpoints by adding urlOrHeaderToken

URL of deployed dev instance (used for testing):

https://xautheverywhere.webknossos.xyz

Steps to test:

  • use token in header instead of as parameter in any datastore or tracingstore route

Issues:

(Please delete unneeded items, merge only when none are left open)

@leowe leowe changed the title add urlTokenOrHeader to all relevant endpoints X-Auth Tokens everywhere (in datastore & tracingstore) Jun 30, 2022
@leowe leowe marked this pull request as ready for review June 30, 2022 12:43
@leowe leowe self-assigned this Jun 30, 2022
@leowe leowe requested a review from fm3 June 30, 2022 12:47
fm3
fm3 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thank you!

@leowe leowe merged commit f496684 into master Jun 30, 2022
@leowe leowe deleted the x-auth-everywhere branch June 30, 2022 13:29
hotzenklotz added a commit that referenced this pull request Jul 4, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into no_…
3f3421e 
…type

* 'master' of github.com:scalableminds/webknossos:
  Ensure unique volume layer names when changing names in frontend (#6289)
  X-Auth Tokens everywhere (in datastore & tracingstore) (#6312)
  add mapping name param for rawcuboid (#6311)
  Fix zooming out for datasets with very large scale (#6304)
  Release 22.07.0 (#6307)
  added Sahil's publication to list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@leowe leowe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All datastore and tracingstore routes should support X-Auth-Token
2 participants
@leowe @fm3