Fix zooming out for datasets with very large scale #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the max zoom value calculation
daniel-wer
reviewed
Jun 27, 2022
| // From that, we calculate the theoretical maximum zoom value. The dataset scale is taken into account, | ||
| // because the entire scene is scaled with that. | ||
| const maxSupportedZoomValue = 2 ** MAX_SUPPORTED_MAGNIFICATION_COUNT * Math.max(...datasetScale); | ||
| const maximumIterationCount = Math.log(maxSupportedZoomValue) / Math.log(ZOOM_STEP_INTERVAL); |
There was a problem hiding this comment.
I think this would be the correct iteration count if the start zoom value were 1. However, it is 1 / ZOOM_STEP_INTERVAL ** 20 so 20 would need to be added.
There was a problem hiding this comment.
Very good point 👍 I adapted the code.
hotzenklotz
added a commit
that referenced
this pull request
Jul 4, 2022
…type * 'master' of github.com:scalableminds/webknossos: Ensure unique volume layer names when changing names in frontend (#6289) X-Auth Tokens everywhere (in datastore & tracingstore) (#6312) add mapping name param for rawcuboid (#6311) Fix zooming out for datasets with very large scale (#6304) Release 22.07.0 (#6307) added Sahil's publication to list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the dataset scale when calculating the maximum iteration limit for the max zoom value determination.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)