Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket loading meter #6269

Merged
merged 17 commits into from
Jun 20, 2022
Merged

Bucket loading meter #6269

merged 17 commits into from
Jun 20, 2022

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jun 10, 2022 •
edited by philippotto
Loading

This PR adds the current average download speed of buckets to the statusbar.

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a dataset in view mode or any tracing.

  • While the buckets are being loaded the download indicator in the statusbar should show the current download speed. Note that the past downloaded buckets of up to 5 seconds are considered for the calculation. This means that up to five seconds long after nothing is downloaded, the status indication still shows that buckets are being downloaded.

  • Hover the download indication in the status bar. A tooltip should show the accumulated downloaded data amount in the form of buckets. To test this do the following:

    • Wait until no buckets are being downloaded anymore. The download speed should be 0.
    • Open the dev tools, open the network tab and start recording. Write down the currently accumulated amount of downloaded bucket data from the tooltip.
    • Reload a visible layer in the layer settings by clicking on the reload icon. The network tab should now list the requests of the layer data being prefetched.
    • Once the download speed is at 0 again the reloading of the layer should be complete. Below the list, in the network tab, there is the data amount of resources. Calculate the difference between the written down value prior to the layer reloading and what is now shown in the download speed tooltip as the total amount. The difference should match about the same amount as what is given by the network tab.

  • I do not know how to test, whether the shown download speed is actually accurate 🤔 ....

Issues:

  • No issue exists for this pr

(Please delete unneeded items, merge only when none are left open)

@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Jun 10, 2022
@hotzenklotz
Copy link
Member

I wonder if we should move the static information - download speed and magnifications - all the way to the right to prevent then from moving around so much, when position/segment id update. What you you think?

image

@philippotto
Copy link
Member

I wonder if we should move the static information - download speed and magnifications - all the way to the right to prevent then from moving around so much, when position/segment id update. What you you think?

image

Good idea 👍 Strictly speaking, all of the infos are dynamic (i.e., they can change), but some change faster than others. I propose the following order:

  • Segment Id (fast changes due to mouse movement)
  • Position (fast changes due to mouse movement)
  • Download Speed (can change without the user doing anything)
  • the other infos should only change due to user actions and they won't change as rapidly. I don't have a strong opinion here, but semantic grouping would be nice (e.g., skeleton-related, volume-related, general...)

@hotzenklotz
Copy link
Member

I propose the following order:

  • Segment Id (fast changes due to mouse movement)
  • Position (fast changes due to mouse movement)
  • Download Speed (can change without the user doing anything)
  • the other infos should only change due to user actions and they won't change as rapidly. I don't have a strong opinion here, but semantic grouping would be nice (e.g., skeleton-related, volume-related, general...)

Sounds good to me.

@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review June 13, 2022 12:56
philippotto
philippotto requested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I left a couple of comments, but overall it already looks pretty good :)

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/data_connection_info.ts Outdated Show resolved Hide resolved
frontend/javascripts/libs/format_utils.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/bucket_data_handling/pullqueue.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/bucket_data_handling/pullqueue.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/data_connection_info.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/data_connection_info.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/data_connection_info.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/statusbar.tsx Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/data_connection_info.ts Outdated Show resolved Hide resolved
philippotto
philippotto approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me 👍

@MichaelBuessemeyer MichaelBuessemeyer enabled auto-merge (squash) June 20, 2022 13:17
@MichaelBuessemeyer MichaelBuessemeyer merged commit 781c2a0 into master Jun 20, 2022
@MichaelBuessemeyer MichaelBuessemeyer deleted the bucket-loading-meter branch June 20, 2022 13:42
hotzenklotz added a commit that referenced this pull request Jun 23, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into no_…
07fb7e8 
…type

* 'master' of github.com:scalableminds/webknossos:
  fix error when loading agglomerate skeleton for single-segment agglomerate (#6294)
  Editable Mappings aka Supervoxel Proofreading (#6195)
  Increase maximum interpolation depth to 100 (#6292)
  Add download modal to dataset view actions (#6283)
  Drop "Explorational" from info tab (#6290)
  Allow version history view in annotations not owned by you (#6274)
  Bucket loading meter (#6269)
  Revert "Merge "Shared Annotations" with "My annotations" (#6230)" (#6286)
  Merge "Shared Annotations" with "My annotations" (#6230)
@philippotto philippotto mentioned this pull request Jul 1, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@MichaelBuessemeyer MichaelBuessemeyer

Labels
frontend new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelBuessemeyer @hotzenklotz @philippotto