-
Notifications
You must be signed in to change notification settings - Fork 27
Merge "Shared Annotations" with "My annotations" #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
frontend/javascripts/dashboard/explorative_annotations_view.tsx
Outdated
Show resolved
Hide resolved
@daniel-wer I think this PR is ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works really well! Thanks for drive-by-improving the types!
Some smaller issues I noticed during testing:
- If I select the annotations tab, the URL switches to
https://dashboardcollab.webknossos.xyz/dashboard/shared
- I would have expected/annotations
, but maybe this is by design - The Owner/Teams filter in the table header works great, but doesn't seem to be taken into consideration by the "Archive All" button. Although only one annotation (which is read-only and cannot be archived) is visible due to the filter, the message reads "Are you sure you want to archive all 2 explorative annotations matching the ..."
- If I archive or reopen an annotation and then switch to the respective view where it can be found, it turns up twice. A page reload "repairs" that.
frontend/javascripts/dashboard/explorative_annotations_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/dashboard/explorative_annotations_view.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel <[email protected]>
… url to change to /shared
…ation and switching to the archived tab in the annotation table
Thanks for catching these bugs! I fixed them all now (plus some additional potential culprits) and also opened #6275, since the entire tab could use some rethinking. Please have another look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one issue left with the "Archive All" functionality - apart from that LGTM 👍
frontend/javascripts/dashboard/explorative_annotations_view.tsx
Outdated
Show resolved
Hide resolved
…e currently rendered annotations
Great catch, @daniel-wer 👍 It took me a bit to find a good workaround, since I found the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you found a workaround! I agree that only modifying the visible results from the active page is even better than the old behavior 👍
This reverts commit ef44b6c.
…type * 'master' of github.com:scalableminds/webknossos: fix error when loading agglomerate skeleton for single-segment agglomerate (#6294) Editable Mappings aka Supervoxel Proofreading (#6195) Increase maximum interpolation depth to 100 (#6292) Add download modal to dataset view actions (#6283) Drop "Explorational" from info tab (#6290) Allow version history view in annotations not owned by you (#6274) Bucket loading meter (#6269) Revert "Merge "Shared Annotations" with "My annotations" (#6230)" (#6286) Merge "Shared Annotations" with "My annotations" (#6230)
* Revert "Revert "Merge "Shared Annotations" with "My annotations" (#6230)" (#6286)" This reverts commit de22b53. * broaden access context and add error chains to annotation public writes * llist access query * remove time logging * naming things Co-authored-by: Florian M <[email protected]> Co-authored-by: Florian M <[email protected]>
URL of deployed dev instance (used for testing):
Steps to test:
Todo:
user
andowner
attribute in annotationsIssues:
(Please delete unneeded items, merge only when none are left open)