Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental auto brush feature #6107

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Remove experimental auto brush feature #6107

merged 3 commits into from
Mar 10, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 10, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • CI should be enough

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Mar 10, 2022
import { getPlaneExtentInVoxelFromStore } from "oxalis/model/accessors/flycam_accessor";
import Dimensions from "oxalis/model/dimensions";

export function* getHalfViewportExtents(activeViewport: OrthoView): Saga<Vector2> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two functions were part of the old automatic_brush_saga.js. I moved them to this file as there are still used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried using half of the image?

Copy link
Member

@normanrz normanrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@philippotto philippotto merged commit b661e28 into master Mar 10, 2022
@philippotto philippotto deleted the remove-tf branch March 10, 2022 14:22
hotzenklotz added a commit that referenced this pull request Mar 29, 2022
* master:
  fix docs formatting
  Remove experimental auto brush feature (#6107)
  Fix markdown issues in docs (#6105)
  Unify long-running RPC timeouts (#6103)
  Disallow deactivating users with active tasks (#6099)
  Add remote origin headers also in error case (#6098)
  Linking layers during upload no longer restricted to public datasets (#6097)
  Fix layer headers layout (#6087)
  Fix more docs links (#6095)
  Update datasets.md (#6094)
  More PR feedback for Docs (#6091)
  Updates to wK Docs (#5995)
  Connectome Tab (#5894)
  Fix duplicating annotations via toggling show archived annotations button and fix downsample modal rendering errors (#6058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid unnecessary warnings caused by tensorflow in CI
2 participants