Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer headers layout #6087

Merged
merged 9 commits into from
Mar 7, 2022
Merged

Fix layer headers layout #6087

merged 9 commits into from
Mar 7, 2022

Conversation

Dagobert42
Copy link
Contributor

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create layers with longer names

Issues:


  • [✓] Ready for review

@Dagobert42
Copy link
Contributor Author

Dagobert42 commented Mar 1, 2022

Here's what it currently looks like:
Screenshot 2022-03-01 at 15 11 19

Two open questions:

  1. The EditableTextLabel made for awkward break behaviour so I moved the edit button into the same span as the label. Could this break the UI in other places? (I briefly checked the spots I found when searching EditableTextLabel and they appeared to be fine.) Nonetheless, the edit button can still appear out of place as can be seen above so maybe there's a better solution.
  2. Is there a better place to add the css rules?

@philippotto
Copy link
Member

Awesome! Major improvement 👍

The EditableTextLabel made for awkward break behaviour so I moved the edit button into the same span as the label. Could this break the UI in other places?

I think, the description here looks weird now:
image

Nonetheless, the edit button can still appear out of place as can be seen above so maybe there's a better solution.

You might have success with the approach (a) from here: https://codepen.io/snookca/pen/JBdBVZ
But if it takes longer than 15 minutes, I'd skip it for now :)

@Dagobert42
Copy link
Contributor Author

Dagobert42 commented Mar 4, 2022

The latest changes to EditableTextLabel also have an impact on TextWithDescription. This leads to changes in the annotations dashboard. However, I'd say that the break-word behaviour there wasn't optimal in the first place:

Before:
Screenshot 2022-03-04 at 11 39 36

After:
Screenshot 2022-03-04 at 11 41 11

I've opened up #6092 to deal with that.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think, this can be merged :) Preferably, on Monday, as we usually try to not push to master on Fridays.

@Dagobert42
Copy link
Contributor Author

Thanks! Will merge on monday :)

@Dagobert42 Dagobert42 merged commit d326c27 into master Mar 7, 2022
@Dagobert42 Dagobert42 deleted the fix-layer-headers-layout branch March 7, 2022 09:19
hotzenklotz added a commit that referenced this pull request Mar 29, 2022
* master:
  fix docs formatting
  Remove experimental auto brush feature (#6107)
  Fix markdown issues in docs (#6105)
  Unify long-running RPC timeouts (#6103)
  Disallow deactivating users with active tasks (#6099)
  Add remote origin headers also in error case (#6098)
  Linking layers during upload no longer restricted to public datasets (#6097)
  Fix layer headers layout (#6087)
  Fix more docs links (#6095)
  Update datasets.md (#6094)
  More PR feedback for Docs (#6091)
  Updates to wK Docs (#5995)
  Connectome Tab (#5894)
  Fix duplicating annotations via toggling show archived annotations button and fix downsample modal rendering errors (#6058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure layer headers look good even with long names
2 participants