Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await Server Replies When Updating User #5392

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Await Server Replies When Updating User #5392

merged 3 commits into from
Apr 14, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 13, 2021

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create second user
  • In admin view, activate, deactivate, change email, should work
  • try deactivating yourself, should fail, and not show as succeeded
  • insert _ <- Fox.failure("nope") in line 319 of UserController.scala
  • subsequent user email/activation updates should fail, and should not seem successful in frontend

Issues:

@fm3 fm3 self-assigned this Apr 13, 2021
@fm3 fm3 requested a review from philippotto April 13, 2021 07:48
philippotto
philippotto approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works great & elegant solution 👍 I just added one small suggestion.

frontend/javascripts/admin/user/user_list_view.js Outdated Show resolved Hide resolved
frontend/javascripts/admin/user/user_list_view.js Outdated Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) April 14, 2021 09:08
@fm3 fm3 merged commit acfb3bc into master Apr 14, 2021
@fm3 fm3 deleted the updateuser-async branch May 3, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“email has been changed” toast shows even if request has failed
2 participants
@fm3 @philippotto