Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“email has been changed” toast shows even if request has failed #4988

Closed
fm3 opened this issue Dec 10, 2020 · 1 comment · Fixed by #5392
Closed

“email has been changed” toast shows even if request has failed #4988

fm3 opened this issue Dec 10, 2020 · 1 comment · Fixed by #5392
Assignees

Comments

@fm3
Copy link
Member

fm3 commented Dec 10, 2020

If you edit a user’s email address in the Users admin view, a failed request leads to both an error toast and a success toast. The success message should not be shown, and the value should not be updated in the list.

@fm3
Copy link
Member Author

fm3 commented Jan 22, 2021

Same for user deactivation. The front-end changes, looking as though the user is now deactivated, independently of whether the request has gone through.

Example: “You cannot deactivate youfself” error shows correctly, but user is shown as deactivated until page refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant