Support uint16 color layers #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wer
changed the title
philippotto
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Awesome refactoring ❤️ Cool to see how the previous float integration enabled this lightweight implementation!
Regarding the histogram: Maybe disable the histogram rendering for uint16 layer (like it's done for float currently). Or do you want to wait with merging until the histogram support is completed?
|
I think I'll disable the histogram for now :) |
|
I've disabled the histogram for all layers but (u)int8 for now. Although it was enabled for uint24 layers before, what was displayed was definitely not correct. |
philippotto
reviewed
Jul 15, 2019
| @@ -135,7 +135,7 @@ class DatasetSettings extends React.PureComponent<DatasetSettingsProps, State> { | |||
| const { alpha, color, intensityRange, isDisabled } = layer; | |||
| let histogram = new Array(256).fill(0); | |||
| if (this.state.histograms && this.state.histograms[layerName]) { | |||
| histogram = this.state.histograms[layerName].histogram; | |||
| ({ histogram } = this.state.histograms[layerName]); | |||
There was a problem hiding this comment.
Interesting, didn't know that syntax for already defined variables!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds uint16 color layer support. Histograms are not working correctly yet, very related to #4095.
Backend ToDo (highest priority first):
the backend doesn't send enough data for uint16 color layer buckets, looks like it automatically assumes uint8the backend doesn't detect uint16 color layers correctly when importing the dataset (detects uint8 instead)URL of deployed dev instance (used for testing):
Steps to test:
Issues: