Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram followup: Refine float/uint16 layer support #4095

Closed
daniel-wer opened this issue May 16, 2019 · 0 comments · Fixed by #4195
Closed

Histogram followup: Refine float/uint16 layer support #4095

daniel-wer opened this issue May 16, 2019 · 0 comments · Fixed by #4195
Assignees
@youri-k @MichaelBuessemeyer
Labels
backend frontend

Comments

@daniel-wer
Copy link
Member

daniel-wer commented May 16, 2019 •
edited
Loading

For float layers we'll need to refine the histogram support a bit. The backend should make a good guess at what the used float range is (by sampling) and send the minRange/maxRange values together with the histogram array data. Same for uint16 layers, probably increase the bucket size to 256.
@daniel-wer daniel-wer mentioned this issue May 20, 2019
Merged
1 task
@daniel-wer daniel-wer mentioned this issue Jul 11, 2019
Merged
6 tasks
@daniel-wer daniel-wer changed the title Histogram followup: Refine float layer support Histogram followup: Refine float/uint16 layer support Jul 11, 2019
youri-k pushed a commit that referenced this issue Jul 18, 2019
add sampling for float layers and better support for uint24 layers #4095
47f731b
@youri-k youri-k mentioned this issue Jul 18, 2019
Merged
6 tasks
daniel-wer pushed a commit that referenced this issue Jul 29, 2019
@youri-k @daniel-wer
Histogram followup (#4195)
f22f6a0 
* add sampling for float layers and better support for uint24 layers #4095

* swapped statements and added changelog entry

* prevent error when no data was found

* implement float/uint16 histogram support

* draw uint24 rgb histograms as one colored histogram

* scalafmt

* specify step size for histogram slider

* fix bucket size calculation for small floats

* only show layer-specific options if layer is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youri-k youri-k

@MichaelBuessemeyer MichaelBuessemeyer

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Histogram followup scalableminds/webknossos
3 participants
@daniel-wer @youri-k @MichaelBuessemeyer