-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce magnifications via task type #4101
Conversation
…ngs with actual enforcement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend LGTM (please update the PR number in evolution file + add migration guide entry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks really good, the active resolution is very helpful! 👍
I started testing, but encountered an issue right away, so I first wanted to let you check that before continuing the testing:
- I created a task type with a min resolution of 4 and a max of 512
- I then created a task with that task type and opened said task
- The task loads at resolution 2-2-2 and I cannot zoom (neither in nor out)
- Tracing can be found at https://enforcemags.webknossos.xyz/annotations/Task/5ce40edb01000091019abcd0#567,216,331,0,1.000,1
frontend/javascripts/oxalis/model/accessors/dataset_accessor.js
Outdated
Show resolved
Hide resolved
Oh, very good catch! I fixed it now. Also, do you notice any performance regressions when zooming? Locally, it appeared a bit laggier to me, but the reason might as well be that I used wk predominantly on deployed instances (where the code is optimized by compilation). In benchmarks, the code wasn't conspicuous. |
@youri-k Could you do this? :) |
Works very well! |
@youri-k Can you update the migration guide? A datastore update is probably not necessary, is it?
Additionally, to the mag enforcement, I also added an "active resolution" hint to the info tab. I think, this is quite useful (at least, it was for testing :)).
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Adapted wk-connect if datastore API changes