Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to enforce specific mag(s) for tasks #4075

Closed
philippotto opened this issue May 7, 2019 · 4 comments · Fixed by #4101
Closed

Allow to enforce specific mag(s) for tasks #4075

philippotto opened this issue May 7, 2019 · 4 comments · Fixed by #4101
Assignees
@philippotto @youri-k
Labels
backend frontend

Comments

@philippotto
Copy link
Member

If the user is zoomed out too far, a toast should appear which says "please zoom in".
@philippotto philippotto mentioned this issue May 8, 2019
Closed
3 tasks
@philippotto philippotto self-assigned this May 9, 2019
@philippotto
Copy link
Member Author

@youri-k Could you add an allowedMagnifications property to the AnnotationSettings case class (plus all moving parts around it). I want to be able to store this property for tasks so that annotations created for a task have that property. The value should have the type Array<Array<int>> so that properties, such as [[1, 1, 1], [2, 2, 2]] are valid. I'm also fine with a general JSON type. The property should be optional. Let me know in case you have questions :)

@philippotto
Copy link
Member Author

On a second thought, I think a JSON type is better. I'll probably use something as {minMagnification: [1, 1, 1], maxMagnification: [4, 4, 4]}.

youri-k pushed a commit that referenced this issue May 16, 2019
add allowed magnifications to annotation settings #4075
6bdce19
@youri-k
Copy link
Contributor

youri-k commented May 16, 2019

@philippotto I added the property as you can see in the commit. I hope you didn't already started working on another branch. Let me know if you need anything more 🙂

@philippotto
Copy link
Member Author

Excellent! I'll use your work tomorrow. However, the CI build failed in Assert schema.sql and evolutions are equal. Can you have a look? :)

@philippotto philippotto mentioned this issue May 21, 2019
Merged
5 tasks
philippotto added a commit that referenced this issue May 28, 2019
@philippotto
Enforce magnifications via task type (#4101)
0b6b8b0 
* add allowed magnifications to annotation settings #4075

* add constraints to sql evolution

* update test csv

* allow to enforce mags

* add enforced mag option to task type form

* finalize enforced magnification feature by connecting task type settings with actual enforcement

* fix linting

* fix mag restriction if provided mag doesn't exist

* incorporate feedback

* add migration guide entry and pr number in evolution #4101

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippotto philippotto

@youri-k youri-k

Labels
backend frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce magnifications via task type scalableminds/webknossos
2 participants
@philippotto @youri-k