Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer Error Message when uploading NML for inaccessible Dataset #3390

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Clearer Error Message when uploading NML for inaccessible Dataset #3390

merged 2 commits into from
Oct 25, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 23, 2018

URL of deployed dev instance (used for testing):

Steps to test:

  • upload NML for non-existant dataset or dataset for which you don’t have access rights
  • should be “Could not access DataSet {0}. Does your team have access?” rather than “Couldn't find the requested resource.”

Issues:

@fm3 fm3 self-assigned this Oct 23, 2018
philippotto
philippotto approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rschwanhold
rschwanhold approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 1918044 into master Oct 25, 2018
@fm3 fm3 deleted the nml-upload-error-message branch October 25, 2018 09:45
jfrohnhofen added a commit that referenced this pull request Oct 26, 2018
@jfrohnhofen
Merge remote-tracking branch 'origin/master' into isosurface
ed670e3 
* origin/master:
  Add debugging methods to visualize wireframe of buckets (#3402)
  fixed bug that selects a just removed layout (#3379)
  Added button to revoke admin rights in frontend (#3378)
  Revert "Add REST API versioning support (#3385)" (#3404)
  Add REST API versioning support (#3385)
  limit number of tasks to be created in one api request (#3386)
  Use correct volume download route in TracingStoreRpcClient (#3403)
  clearer error message when uploading nml for inaccessible dataset (#3390)
  Refactored dropdown item events (#3383)
  Show dataset extent in right menu tab (#3371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwanhold rschwanhold rschwanhold approved these changes

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend should show appropriate error message if NML is uploaded for a non-existent dataset
3 participants
@fm3 @philippotto @rschwanhold