-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added button to revoke admin rights in frontend #3378
Conversation
@daniel-wer Could you please also check the snapshots/failed e2e tests before I update the snapshots. In my opinion it looks like the snapshots failed because I added an additional button, but I am not sure whether it is also more because it says that things were added and also removed 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I'll test once the CI builds successfully :)
Regarding the e2e tests, the -
in front of a line means the line is missing in the snapshot but was encountered during testing (so these are the lines you added), which is misleading, unfortunately. Then, there are also some lines that you supposedly removed AND added, not sure why the differ is not able to recognize this correctly. Please update the snapshots and this PR should be good to go :)
…webknossos into add-revoking-admin-rights
Works as expected :) |
* origin/master: Add debugging methods to visualize wireframe of buckets (#3402) fixed bug that selects a just removed layout (#3379) Added button to revoke admin rights in frontend (#3378) Revert "Add REST API versioning support (#3385)" (#3404) Add REST API versioning support (#3385) limit number of tasks to be created in one api request (#3386) Use correct volume download route in TracingStoreRpcClient (#3403) clearer error message when uploading nml for inaccessible dataset (#3390) Refactored dropdown item events (#3383) Show dataset extent in right menu tab (#3371)
* Revert "Add debugging methods to visualize wireframe of buckets (#3402)" This reverts commit 8238820. * Revert "fixed bug that selects a just removed layout (#3379)" This reverts commit 8b16ef3. * Revert "Added button to revoke admin rights in frontend (#3378)" This reverts commit 2fc489c. * Revert "Revert "Add REST API versioning support (#3385)" (#3404)" This reverts commit 49819b2. * move /api routes prefix to webknossosApi.routes * reorganize routing to handle all combinations of local datastore/tracingstore etc * update migrations
This PR adds a button next to the
grant admin rights
that revokes the admin rights from a user.URL of deployed dev instance (used for testing):
Steps to test:
consider
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Needs datastore update after deployment