backend unit tests for nml parser and writer #2829
Conversation
|
@jstriebel these tests currently run in the |
|
@youri-k, do you mean the docker-compose service |
|
Right |
youri-k
changed the title
|
@youri-k: I just added a docker-compose service |
| @@ -140,7 +140,7 @@ object NmlParser extends LazyLogging with ProtoGeometryImplicits { | |||
| } | |||
|
|
|||
| private def parseEditRotation(node: NodeSeq) = { | |||
| node.headOption.flatMap(parseRotation) | |||
| node.headOption.flatMap(parseRotationForParams) | |||
There was a problem hiding this comment.
I guess this fixes a bug you found with the tests?
There was a problem hiding this comment.
Yes it is because of difference in parsing EditRotation of nodes and the general param
test/backend/NMLUnitTestSuite.scala
Outdated
|
|
||
| def getObjectId = ObjectId.fromBsonId(BSONObjectID.generate) | ||
|
|
||
| def getParsedTracing(tracing: SkeletonTracing) = { |
There was a problem hiding this comment.
I would rather rename this to something more active, as it is not a typical getter. Maybe writeAndParseTracing.
test/backend/NMLUnitTestSuite.scala
Outdated
| } | ||
| } | ||
|
|
||
| "NML Parser" should "throw an error for invalid comment state" in { |
There was a problem hiding this comment.
Please add why this is invalid here.
test/backend/NMLUnitTestSuite.scala
Outdated
| //TODO: The parser currently doesn't check this | ||
| } | ||
|
|
||
| it should "throw an error for invalid branchPoint state" in { |
There was a problem hiding this comment.
Please add why this is invalid here.
test/backend/NMLUnitTestSuite.scala
Outdated
| //TODO: The parser currently doesn't check this | ||
| } | ||
|
|
||
| it should "throw an error for invalid edge state" in { |
…sos into backend-unit-tests
…e-validation improve the backend tree validator
Steps to test:
sbt "test-only *NMLUnitTestSuite"in wK directory to see the tests runningIssues: