Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend nml parser should check more invalid state #2830

Closed
3 tasks done
youri-k opened this issue Jun 29, 2018 · 0 comments
Closed
3 tasks done

backend nml parser should check more invalid state #2830

youri-k opened this issue Jun 29, 2018 · 0 comments

Comments

@youri-k
Copy link
Contributor

youri-k commented Jun 29, 2018

  • invalid comment state
  • invalid branchPoint state
  • invalid groupId state

This should be done to check as much as the frontend does.

@youri-k youri-k self-assigned this Jun 29, 2018
youri-k added a commit that referenced this issue Jul 9, 2018
* [WIP] backend unit test for nml parser

* [WIP] Unit Tests for Backend

* [WIP] backend unit test now work for serializing and parsing #2826

* nml tests now work similar to the frontend tests

* fix imports

* mark test as working to enable ci build #2829

* fix compiler errors and add some tests #2829

* enhance the backend tree validator with some functions the frontend already uses #2830

* add docker-compose service backend-tests

* CI: add backend tests

* e2e tests: move invariant config to End2EndSpec.scala

* implement pr advice #2829

* implement some of the pr advice #2832

* implement pr feedback #2832

* implement pr advice #2829

* fix merge errors and make code DRYer #2832

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants