Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wk: update generated client, using mag and owner #760

Merged
merged 6 commits into from
Jul 5, 2022
Merged

wk: update generated client, using mag and owner #760

merged 6 commits into from
Jul 5, 2022

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented Jul 5, 2022 •
edited
Loading

Description:

Update the generated client for the webknossos package and adapt the usage:

  • use mag instead of resolution
  • use owner instead of user

Issues:

Todos:

  • Updated Changelog
  • Updated Documentation

@jstriebel jstriebel requested review from fm3 and philippotto July 5, 2022 07:51
@jstriebel jstriebel self-assigned this Jul 5, 2022
fm3
fm3 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Please add a changelog entry (and have a look at the tests?), then this should be good to go

fm3
fm3 reviewed Jul 5, 2022
View reviewed changes
webknossos/Changelog.md Outdated Show resolved Hide resolved
@jstriebel jstriebel enabled auto-merge (squash) July 5, 2022 09:08
@jstriebel jstriebel mentioned this pull request Jul 5, 2022
Closed
4 tasks
@jstriebel jstriebel merged commit 300a9ca into master Jul 5, 2022
@jstriebel jstriebel deleted the update-client-use-mag-and-owner branch July 5, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@philippotto philippotto Awaiting requested review from philippotto

Assignees

@jstriebel jstriebel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Annotation user to owner Adapt to new datastore API (mag instead of zoomStep)
2 participants
@jstriebel @fm3